fix(publish): underscore image names + existing_tag recovery dispatch - #240
Open
sebasnallar wants to merge 9 commits into
Open
fix(publish): underscore image names + existing_tag recovery dispatch#240sebasnallar wants to merge 9 commits into
sebasnallar wants to merge 9 commits into
Conversation
Beta to main
Beta to main
…h-annotations fix(k8s): stop hardcoding the CloudWatch logging annotations
…e-cloudwatch-annotations Revert "fix(k8s): stop hardcoding the CloudWatch logging annotations"
Beta to main
Release 1.16.1
v1.16.1 failed to publish scheduled-task and containers-datadog: the ECR repositories don't exist, and the names were wrong anyway — the images are scopes/scheduled_task and scopes/containers_datadog (underscores, matching the source directories). Renames image_name, the artifact registration repository and the release table for both. Also adds a workflow_dispatch existing_tag input: a tag push runs the workflow at the tagged commit, so a fix on main can never reach an already-pushed tag without a dispatch path. CLI install moves from the alpha-packages channel to the released 2.10.0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Passes ref: existing_tag to docker-build-push-ecr (via actions-nullplatform#100) so a recovery dispatch builds the tagged content, not the main head the dispatch ran from. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
Author
|
Updated: the three build calls now pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened with v1.16.1
Run 33766821675 is a failure, not green:
scopes/containerspushed and registered fine, but scheduled-task and containers-datadog never pushed anywhere — their ECR repositories don't exist (verified against the registry API: neither the hyphen nor the underscore names exist), and ECR never creates repositories on push. So there is nothing wrongly-named to clean up; the fix is free to pick the right names.Changes
scopes/scheduled-task→scopes/scheduled_taskandscopes/containers-datadog→scopes/containers_datadog(underscores, matching the source directories) inimage_name, thenp artifact create --repository, and the release table.scopes/containersuntouched.workflow_dispatchwithexisting_tag: a tag push runs the workflow at the tagged commit, so this fix can never reach v1.16.1 via re-run or tag re-push — the dispatch path runs the current workflow for an existing tag. Everygithub.ref_nameuse falls back throughinputs.existing_tag ||.alpha-packageschannel → released 2.10.0.To recover v1.16.1 (in order)
gh workflow run publish-images.yml --repo nullplatform/scopes -f existing_tag=v1.16.1The re-run re-registers the containers artifact identically (idempotent upsert) and the release upsert is digest-guarded, so nothing duplicates.
🤖 Generated with Claude Code